<?php
/**
* PHPCompatibility, an external standard for PHP_CodeSniffer.
*
* @package PHPCompatibility
* @copyright 2012-2020 PHPCompatibility Contributors
* @license https://opensource.org/licenses/LGPL-3.0 LGPL3
* @link https://github.com/PHPCompatibility/PHPCompatibility
*/
namespace PHPCompatibility\Sniffs\ParameterValues;
use PHP_CodeSniffer\Files\File;
use PHP_CodeSniffer\Util\Tokens;
use PHPCompatibility\AbstractFunctionCallParameterSniff;
use PHPCompatibility\Helpers\ScannedCode;
use PHPCSUtils\Utils\MessageHelper;
/**
* Detect the use of assertions passed as a string.
*
* PHP 7.2:
* > Usage of a string as the assertion became deprecated. It now emits an E_DEPRECATED
* > notice when both assert.active and zend.assertions are set to 1.
*
* PHP 8.0:
* > assert() will no longer evaluate string arguments, instead they will be treated
* > like any other argument. `assert($a == $b)` should be used instead of `assert('$a == $b')`.
*
* PHP version 7.2
* PHP version 8.0
*
* @link https://wiki.php.net/rfc/deprecations_php_7_2#assert_with_string_argument
* @link https://github.com/php/php-src/blob/69888c3ff1f2301ead8e37b23ff8481d475e29d2/UPGRADING#L350-L354
* @link https://www.php.net/manual/en/function.assert.php#refsect1-function.assert-changelog
*
* @since 10.0.0
*/
final class RemovedAssertStringAssertionSniff extends AbstractFunctionCallParameterSniff
{
/**
* Functions to check for.
*
* @since 10.0.0
*
* @var array<string, true>
*/
protected $targetFunctions = [
'assert' => true,
];
/**
* Target tokens.
*
* If there is anything but any of these tokens in the parameter, we bow out as undetermined.
*
* @since 10.0.0
*
* @var array<int|string, int|string>
*/
private $targetTokens = [];
/**
* Returns an array of tokens this test wants to listen for.
*
* @since 10.0.0
*
* @return array<int|string>
*/
public function register()
{
// Set $targetTokens only once.
$this->targetTokens = Tokens::$emptyTokens;
$this->targetTokens += Tokens::$stringTokens + Tokens::$heredocTokens;
$this->targetTokens[\T_STRING_CONCAT] = \T_STRING_CONCAT;
return parent::register();
}
/**
* Do a version check to determine if this sniff needs to run at all.
*
* @since 10.0.0
*
* @return bool
*/
protected function bowOutEarly()
{
return (ScannedCode::shouldRunOnOrAbove('7.2') === false);
}
/**
* Process the parameters of a matched function.
*
* @since 10.0.0
*
* @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
* @param int $stackPtr The position of the current token in the stack.
* @param string $functionName The token content (function name) which was matched.
* @param array $parameters Array with information about the parameters.
*
* @return int|void Integer stack pointer to skip forward or void to continue
* normal file processing.
*/
public function processParameters(File $phpcsFile, $stackPtr, $functionName, $parameters)
{
if (isset($parameters[1]) === false) {
return;
}
$targetParam = $parameters[1];
$hasOther = $phpcsFile->findNext($this->targetTokens, $targetParam['start'], ($targetParam['end'] + 1), true);
if ($hasOther !== false) {
// Some other token was found, unclear whether this is really a text string. Bow out.
return;
}
$error = 'Using a string as the assertion passed to assert() is deprecated since PHP 7.2%s. Found: %s';
$code = 'Deprecated';
$isError = false;
$data = [
'',
$targetParam['clean'],
];
if (ScannedCode::shouldRunOnOrAbove('8.0') === true) {
$data[0] = ' and removed since PHP 8.0';
$isError = true;
$code = 'Removed';
}
MessageHelper::addMessage($phpcsFile, $error, $targetParam['start'], $isError, $code, $data);
}
}